Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActionInput): Show trailing button even for empty input #4251

Merged
merged 1 commit into from Jun 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 22, 2023

☑️ Resolves

Show the trailing button even for empty value as long as it is enabled.

🖼️ Screenshots

🏚️ Before 🏡 After
image image
vokoscreenNG-2023-06-22_20-19-59.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…s enabled

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews feature: actions Related to the actions components labels Jun 22, 2023
@susnux susnux requested review from artonge, szaimen and a team June 22, 2023 18:22
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen merged commit 5a5fea0 into master Jun 22, 2023
16 checks passed
@szaimen szaimen deleted the fix/action-input-4201 branch June 22, 2023 20:51
@szaimen
Copy link
Contributor

szaimen commented Jun 22, 2023

/backport to stable7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input field should always show the confirm arrow and not change its length while editing
3 participants