Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcModal): prev/next color and sizing fix #4368

Merged
merged 1 commit into from Aug 1, 2023
Merged

fix(NcModal): prev/next color and sizing fix #4368

merged 1 commit into from Aug 1, 2023

Conversation

skjnldsv
Copy link
Contributor

Before After
2023-07-27_21-30_1 2023-07-27_21-30

@skjnldsv
fix(NcModal): prev/next color and sizing fix
0e7db4c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: modal Related to the modal component labels Jul 27, 2023
@skjnldsv skjnldsv requested review from szaimen and a team July 27, 2023 19:31
@skjnldsv skjnldsv self-assigned this Jul 27, 2023
@skjnldsv skjnldsv requested review from susnux and Pytal and removed request for a team July 27, 2023 19:31
szaimen
szaimen approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@susnux
Copy link
Contributor

susnux commented Jul 27, 2023

BTW we need to fix the the actions and title, because it is lacking contrast

@skjnldsv skjnldsv merged commit 090ce20 into master Aug 1, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/modal branch August 1, 2023 15:24
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @susnux @szaimen