fix(NcButton): Improve alignment documentation to show all variants. #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
enhancement
skjnldsv
approved these changes
Aug 2, 2023
marcoambrosini
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Continuation of the discussion of #4366
This adds the example from @ShGKme which is more complete for showing all supported property values.
So do we want to show all supported types or only the default ones?
From my point of view there is no benefit in hiding, but we should rather have a line in the style guide when to use which button type. (Because even before this feature was available users of the library simply hacked this behavior).
🖼️ Screenshots
🏁 Checklist