Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix header size on mobile #4420

Merged
merged 1 commit into from Aug 15, 2023
Merged

try to fix header size on mobile #4420

merged 1 commit into from Aug 15, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 15, 2023 •
edited

Close nextcloud/server#39881

Before After
image image

@szaimen szaimen added 2. developing Work in progress design Design, UX, interface and interaction design labels Aug 15, 2023
@szaimen
try to fix header size on mobile
0e797c4 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 15, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

/backport to stable7

@szaimen szaimen marked this pull request as ready for review August 15, 2023 10:16
@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

cc @nimishavijay @jancborchardt @marcoambrosini

jancborchardt
jancborchardt approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work to give a bit more space, nice!

@susnux susnux merged commit bbb7ffc into master Aug 15, 2023
17 checks passed
@susnux susnux deleted the enh/noid/fix-header-size branch August 15, 2023 13:10
@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

btw, does the backport bot work here?

@susnux
Copy link
Contributor

susnux commented Aug 15, 2023

btw, does the backport bot work here?

good question, before the migration yes but maybe @skjnldsv or @nickvergessen can help?

@szaimen szaimen mentioned this pull request Aug 15, 2023
Merged
@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

#4421

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 15, 2023 •
edited

Unfortunately the bot is scoped under the @nextcloud org :/
https://docs.github.com/en/apps/creating-github-apps/registering-a-github-app/making-a-github-app-public-or-private

We would have to make it public, so not great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@artonge artonge Awaiting requested review from artonge

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header too crowded for mobile
5 participants
@szaimen @susnux @skjnldsv @jancborchardt @AndyScherzinger