fix: exports field of package used deprecated syntax
#4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eslint issues of libraries using the package like: > "@nextcloud/vue/dist/Components/NcButton.js" is not found n/no-missing-import Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
ShGKme
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Looks correct according to the current documentation.
The API was deprecated since Node 16 (though, I have found neither mentions about deprecation in Node 14 nor mentions about trailing slash pattern support).
https://nodejs.org/docs/latest-v16.x/api/packages.html#subpath-folder-mappings
Pytal
approved these changes
Aug 22, 2023
Pytal
added
4. to release
See DEP0148: Deprecated since Node 14 and removed with Node 17: |
|
Please set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fixes eslint issues of libraries using the package like:
Using directory exports is deprecated since Node 14, instead wildcard exports should be used.
This causes eslint-plugin-n to fail because it does not support the deprecated syntax.
See server PR as example of failing lint: https://github.com/nextcloud/server/actions/runs/5908640226/job/16028330790?pr=39970
🏁 Checklist