Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem) - remove empty wrapper for additional elements from DOM if not needed #4438

Merged
merged 1 commit into from Aug 22, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix #Open conversations: Text not vertically aligned nextcloud/spreed#10210
  • Before component:
    • ...creates an empty <span> wrapper and fill it with children conditionally;
    • ...removes wrapper on hover (or if menu actions are forced) - look at bold text jumping;
  • After component:
    • ...creates wrapper only if children should be there, otherwise skips;
    • ... hides wrapper with display: none on hover

🖼️ Screenshots (Talk)

🏚️ Before 🏡 After
open-chats-before open-chats-after

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Aug 20, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Aug 20, 2023
@Antreesy Antreesy self-assigned this Aug 20, 2023
@Antreesy
Copy link
Contributor Author

/backport to stable7

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 22, 2023
@Pytal Pytal merged commit c7e1f16 into master Aug 22, 2023
16 checks passed
@Pytal Pytal deleted the feat/noid/nclistitem-remove-redundant-wrapper branch August 22, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants