Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make smart picker modal close button tertiary #4441

Merged
merged 1 commit into from Aug 23, 2023
Merged

Make smart picker modal close button tertiary #4441

merged 1 commit into from Aug 23, 2023

Conversation

julien-nc
Copy link
Contributor

We usually have tertiary button to close modals.

@julien-nc
make smart picker modal close button tertiary
002a8f6 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: smart picker labels Aug 21, 2023
@julien-nc julien-nc added this to the 7.12.3 milestone Aug 21, 2023
ShGKme
ShGKme approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything with NcModal's built-in close button that prevents using it?

@skjnldsv skjnldsv merged commit 64240ea into master Aug 23, 2023
16 checks passed
@skjnldsv skjnldsv deleted the enh/smart-picker-modal-close-button branch August 23, 2023 14:39
@julien-nc
Copy link
Contributor Author

Is there anything with NcModal's built-in close button that prevents using it?

As far as I remember it was to prevent closing the modal when ESC is pressed. The picker inside the modal handles this event.

@ShGKme
Copy link
Contributor

ShGKme commented Aug 24, 2023

Is there anything with NcModal's built-in close button that prevents using it?

As far as I remember it was to prevent closing the modal when ESC is pressed. The picker inside the modal handles this event.

Cool, then it is a11y related issue, will be fixed soon.
It is not ok that ESC in a sub element closes the modal :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: smart picker
Projects
None yet
Milestone
7.12.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julien-nc @ShGKme @skjnldsv