Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove border from sidebar tabs #4449

Merged
merged 2 commits into from Aug 23, 2023
Merged

Remove border from sidebar tabs #4449

merged 2 commits into from Aug 23, 2023

Conversation

marcoambrosini
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-08-23 at 20 48 46 | Screenshot 2023-08-23 at 20 48 23

@marcoambrosini
Improve active state of listitem
2412bbf 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Remove borders from sidebar tabs
d59c939 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini marcoambrosini self-assigned this Aug 23, 2023
@marcoambrosini marcoambrosini added enhancement New feature or request 3. to review Waiting for reviews labels Aug 23, 2023
szaimen
szaimen approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jancborchardt
jancborchardt approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good design-wise for the sidebar.

@skjnldsv skjnldsv merged commit c646c65 into master Aug 23, 2023
16 checks passed
@skjnldsv skjnldsv deleted the remove-border-from-sidebar-tabs branch August 23, 2023 14:39
@Antreesy Antreesy mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@szaimen szaimen szaimen approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar tabs design update
4 participants
@marcoambrosini @jancborchardt @szaimen @skjnldsv