fix(NcCheckboxRadioSwitch): If no text is provided the element should be a circle #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d focus outline should be a circle Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
susnux
requested review from
raimund-schluessler,
skjnldsv,
Pytal and
marcoambrosini
15 tasks
marcoambrosini
approved these changes
Aug 23, 2023
Pytal
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
We use the NcCheckboxRadioSwitch also for e.g. the files list in the FilePicker and the files app, on the table no text is used.
But even if the text is empty the element is still displayed, resulting in an oval shape of the hover state and focus visible outline.
Moreover we use 24x24px icons for checkboxes and radio, so the padding was incorrectly set as if we use 20x20px icons.
🖼️ Screenshots
🏁 Checklist