Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem) don't force blur action menu on tab #4458

Merged
merged 1 commit into from Aug 24, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 24, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before

Screencast.from.24.08.2023.12.01.27.webm

🏡 After

Screencast.from.24.08.2023.11.57.53.webm

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Aug 24, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Aug 24, 2023
@Antreesy Antreesy self-assigned this Aug 24, 2023
@nickvergessen
Copy link
Contributor

/backport to stable7

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenrecording

@Antreesy Antreesy merged commit 32c0348 into master Aug 24, 2023
16 checks passed
@Antreesy Antreesy deleted the fix/noid/nc-list-item-tabbing branch August 24, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer tab over conversation to the group/user list
3 participants