Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Do not add border to single select option #4475

Merged
merged 1 commit into from Aug 28, 2023
Merged

fix(NcSelect): Do not add border to single select option #4475

merged 1 commit into from Aug 28, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 25, 2023 •
edited

Followup #4434

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
fix(NcSelect): Do not add border to single select option
46dee7d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Aug 25, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 25, 2023
@Pytal Pytal self-assigned this Aug 25, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 28, 2023
@Pytal Pytal merged commit 2a364aa into master Aug 28, 2023
16 checks passed
@Pytal Pytal deleted the fix/selected-option-border branch August 28, 2023 16:46
@Pytal Pytal mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @JuliaKirschenheuter @ShGKme