Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcRichContenteditable) - add different output appearance in examples #4485

Merged
merged 2 commits into from Aug 31, 2023
Merged

feat(NcRichContenteditable) - add different output appearance in examples #4485

merged 2 commits into from Aug 31, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 30, 2023 •
edited

☑️ Resolves

  • Raise awareness how the component handles and transfers strings
  • May help to identify some issues before they reach release
  • Cover frequent usecases:
    • render as a simple message
    • send to server with JSON.stringify()
    • interact with <NcRichText /> (with markdown enabled)

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Wording suggestions?
  • Another outputs?
  • Visual check

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: documentation Related to the documentation feature: rich-contenteditable Related to the rich-contenteditable components labels Aug 30, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Aug 30, 2023
@Antreesy Antreesy self-assigned this Aug 30, 2023
ShGKme
ShGKme approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add more examples or NcRichContenteditable input to the NcRichText documentation?

src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/noid/richcontenteditable-examples branch from b938b03 to d53556c Compare August 30, 2023 14:28
@Antreesy Antreesy requested a review from ShGKme August 30, 2023 14:28
@Antreesy Antreesy mentioned this pull request Aug 30, 2023
Merged
5 tasks
@Antreesy
add examples for NcRichContenteditable.vue output
31db00d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/richcontenteditable-examples branch from d53556c to 31db00d Compare August 31, 2023 07:25
@Antreesy Antreesy merged commit a53da1e into master Aug 31, 2023
16 checks passed
@Antreesy Antreesy deleted the feat/noid/richcontenteditable-examples branch August 31, 2023 07:29
@Antreesy Antreesy mentioned this pull request Sep 6, 2023
Merged
1 task
@Antreesy Antreesy mentioned this pull request Sep 6, 2023
Merged
2 tasks
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Pytal approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews enhancement New feature or request feature: documentation Related to the documentation feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Antreesy @Pytal @ShGKme