Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Add nav to header menu #4487

Merged
merged 2 commits into from Sep 14, 2023
Merged

enh(a11y): Add nav to header menu #4487

merged 2 commits into from Sep 14, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 30, 2023

Summary

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 30, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 30, 2023
@Pytal Pytal self-assigned this Aug 30, 2023
@Pytal Pytal mentioned this pull request Aug 29, 2023
Closed
13 tasks
@Pytal
enh(a11y): Add nav to header menu
289bfe2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Contributor Author

Pytal commented Sep 8, 2023

aria-describedby added for extended description i.e. "Avatar of admin - do not disturb"

@Pytal Pytal requested a review from ShGKme September 8, 2023 01:31
@Pytal
enh(a11y): Add additional description for trigger button
c261336 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from skjnldsv September 14, 2023 01:20
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 14, 2023
@Pytal Pytal merged commit 3c6f416 into master Sep 14, 2023
16 checks passed
@Pytal Pytal deleted the enh/a11y/header-menu-nav branch September 14, 2023 15:09
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @artonge @ShGKme