Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat and fix: NcCheckboxRadioSwitch required prop and input position fix #4488

Merged
merged 2 commits into from Aug 31, 2023
Merged

feat and fix: NcCheckboxRadioSwitch required prop and input position fix #4488

merged 2 commits into from Aug 31, 2023

Conversation

skjnldsv
Copy link
Contributor

Before After
2023-08-31_08-41 2023-08-31_08-40
image image

@skjnldsv
feat(NcCheckboxRadioSwitch): add required prop
8d6f155 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(NcCheckboxRadioSwitch): hidden input position
6949047 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Aug 31, 2023
@skjnldsv skjnldsv added this to the 8.0.0 milestone Aug 31, 2023
@skjnldsv skjnldsv self-assigned this Aug 31, 2023
@skjnldsv skjnldsv changed the title feat(NcCheckboxRadioSwitch): add required prop feat and fix: NcCheckboxRadioSwitch required prop and input position fix Aug 31, 2023
@skjnldsv skjnldsv changed the title feat and fix: NcCheckboxRadioSwitch required prop and input position fix feat and fix: NcCheckboxRadioSwitch required prop and input position fix Aug 31, 2023
@skjnldsv skjnldsv merged commit 1a4caa1 into master Aug 31, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/checkbox-radio-switch branch August 31, 2023 08:27
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @raimund-schluessler @szaimen