Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EmptyContent): svg max size #4496

Merged
merged 1 commit into from Sep 1, 2023
Merged

fix(EmptyContent): svg max size #4496

merged 1 commit into from Sep 1, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 1, 2023 •
edited

Before After
image image

Explanations

There is a conflict when used with the NcIconSvgWrapper
image

@skjnldsv
fix(EmptyContent): svg max size
3615af9 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: emptycontent Related to the emptycontent component labels Sep 1, 2023
@skjnldsv skjnldsv self-assigned this Sep 1, 2023
@skjnldsv skjnldsv merged commit 7e2dcd2 into master Sep 1, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/emptycontent-svg-size branch September 1, 2023 11:25
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@szaimen szaimen szaimen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working feature: emptycontent Related to the emptycontent component regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @raimund-schluessler @szaimen