allow type property for NcAppNavigationNew #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartcafe
changed the title
|
@skjnldsv Anyone willing/able to review this, before real merge conflicts arise? I can't edit here anymore since the movement to nextcloud-libraries. Would love to close the issue in our repo. |
susnux
reviewed
Oct 2, 2023
susnux
added
bug
susnux
requested review from
jancborchardt,
raimund-schluessler,
JuliaKirschenheuter and
Pytal
jancborchardt
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Looks good design-wise. :)
Btw @dartcafe separate topic, but slight enhancement to the button wording: "New poll". Shorter and "poll" lowercase. :)
susnux
approved these changes
Oct 2, 2023
Signed-off-by: dartcafe <github@dartcafe.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: René Gieling <github@dartcafe.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist