Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcEmojiPicker): Do not set padding for the search input label #4577

Merged
merged 1 commit into from Sep 26, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 26, 2023

☑️ Resolves

The "hacked" padding into the label broke when we introduced the internal label, so remove the custom styles on the label.

🖼️ Screenshots

Focus on the search input label:

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: emoji picker Related to the emoji picker component labels Sep 26, 2023
@susnux susnux added this to the 8.0.0 milestone Sep 26, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux merged commit b641a59 into master Sep 26, 2023
15 checks passed
@susnux susnux deleted the fix/emojipicker-search-label branch September 26, 2023 13:59
@Pytal Pytal mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: emoji picker Related to the emoji picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants