fix(NcInputField): Adjust styling of the internal label #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
jancborchardt,
raimund-schluessler,
marcoambrosini and
nimishavijay
susnux
force-pushed
the
fix/input-field-style
branch
from
066ff1f
to
64aa149
Compare
ShGKme
approved these changes
Sep 26, 2023
jancborchardt
previously requested changes
Sep 27, 2023
* Add note that the internal label is only recommended when the background matches * Make border of the internal label rounded (needed to adjust the padding as well) * Perfect pixel align label, placeholder and content Co-authored-by: Marco <marcoambrosini@icloud.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/input-field-style
branch
from
e20ecde
to
b4b8860
Compare
jancborchardt
approved these changes
Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
From today's design review call:
🖼️ Screenshots
(added background color to make the border more visible, e.g. like on the login)
🏁 Checklist