Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EmptyContent): ensure proper custom icon size #4584

Merged
merged 1 commit into from Oct 3, 2023

Conversation

raimund-schluessler
Copy link
Contributor

Since we had to explicitly set the icon size of NcIconSvgWrapper in #4557 to make it work on iOS, we now have to overwrite it here to not rely on the order of the files bundling.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: emptycontent Related to the emptycontent component labels Sep 28, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Sep 28, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2023
@Pytal Pytal merged commit 67278ca into master Oct 3, 2023
15 checks passed
@Pytal Pytal deleted the fix/noid/empty-content-icon-size branch October 3, 2023 23:35
@Pytal Pytal mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: emptycontent Related to the emptycontent component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants