Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSettingsSection): remove incorrect role=note on doc link #4594

Merged
merged 1 commit into from Oct 2, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 2, 2023

☑️ Resolves

🖼️ Visual Changes

No visual changes

🔊 Audible Changes

image

Before After
heading level 2 External documentation for Two-Factor Authentication visited link heading level 2

🚧 Tasks

  • Remove role="note"
  • Remove aria-label that duplicates title (no change, no unneeded)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: settings Related to the settings component labels Oct 2, 2023
@ShGKme ShGKme self-assigned this Oct 2, 2023
@ShGKme ShGKme merged commit f3a5740 into master Oct 2, 2023
15 checks passed
@ShGKme ShGKme deleted the fix/remove-role-note-in-settings-section-docs-link branch October 2, 2023 20:07
@Pytal Pytal mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities backport-request bug Something isn't working feature: settings Related to the settings component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: remove role="note" from all links where it should not be
3 participants