New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcTextArea): implement new textarea component #4605
Conversation
eedddeb
to
5ff9853
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
5ff9853
to
4d09444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, this component looks very similar to NcInputField
with similar interface, states, helper/hint text, public methods, and label. Except a trailing button.
Could it be possible to add a new prop in NcInputField
like multiline
/textarea
instead and use dynamic component?
Maybe making this component a wrapper around NcInputField
like NcTextField
if we need to assign more custom things.
That was my plan at first but doing so would require a lot of hacks. For example trailing buttons, and leading icons don't make sense here. They look weird as the text extends to multiple lines. The success and error states are tied to leading icons in I went with a custom component to reduce complexity and narrow the scope of |
I agree with @st3iny, the NcInputField is a wrapper around the native input field and this one is a wrapper around the native textarea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked it via https://deploy-preview-4605--nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextarea looks good
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
None
🏁 Checklist