Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcIconSvgWrapper)!: remove ID from svg #4607

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat(NcIconSvgWrapper)!: remove ID from svg #4607

merged 3 commits into from
Oct 5, 2023

Commits on Oct 4, 2023

  1. feat(NcIconSvgWrapper)!: remove ID from svg 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    df2eedd View commit details
    Browse the repository at this point in the history

  2. fix(NcIconSvgWrapper): remove empty aria attrs 

    Note: arria-hidden="false" doesn't add an attribute in Vue 2, but does in Vue 3.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c0982c9 View commit details
    Browse the repository at this point in the history

  3. test(NcIconSvgWrapper): add unit tests 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8e92ce1 View commit details
    Browse the repository at this point in the history