Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcIconSvgWrapper): allow to render raw svg paths #4643

Merged
merged 2 commits into from Oct 13, 2023
Merged

feat(NcIconSvgWrapper): allow to render raw svg paths #4643

merged 2 commits into from Oct 13, 2023

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

This allows to render raw SVG paths which prevents the overhead of having to sanitize the SVG icon for use in v-html.

@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Oct 13, 2023
susnux
susnux previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, less overhead ✨

I think you need to add @mdi/js as a dependency.

@susnux susnux self-requested a review October 13, 2023 13:56
@susnux susnux dismissed their stale review October 13, 2023 13:57

Did not meant to approve, should be a comment

@raimund-schluessler
feat: allow to render raw svg paths
f597e50 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Contributor Author

I think you need to add @mdi/js as a dependency.

Yeah, you were a bit to fast to review, I wasn't done yet 🙈 🙂 I also had to set the viewBox of the svg. Now it should be good.

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 13, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review October 13, 2023 17:02
@raimund-schluessler raimund-schluessler changed the title feat: allow to render raw svg paths feat(NcIconSvgWrapper): allow to render raw svg paths Oct 13, 2023
Pytal
Pytal reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce duplication by putting the identical props in a computed property then v-bind them ?

@raimund-schluessler
feat(NcIconSvgWrapper): reduce code duplication
7e6049a 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Contributor Author

Can we reduce duplication by putting the identical props in a computed property then v-bind them ?

Sure, why not. I adjusted it.

@Pytal Pytal merged commit d73be2f into master Oct 13, 2023
15 checks passed
@Pytal Pytal deleted the feat/noid/svg-path branch October 13, 2023 21:42
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: icon-svg-wrapper
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raimund-schluessler @susnux @Pytal @ShGKme