Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the resource type on RelatedResourcesPanel #4662

Merged
merged 1 commit into from Oct 20, 2023
Merged

Add the resource type on RelatedResourcesPanel #4662

merged 1 commit into from Oct 20, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 17, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@GretaD GretaD added the 3. to review Waiting for reviews label Oct 17, 2023
@GretaD GretaD self-assigned this Oct 17, 2023
@Pytal
Copy link
Contributor

Pytal commented Oct 17, 2023

Also needs the new limit query param from nextcloud/related_resources#303 @GretaD

@GretaD GretaD mentioned this pull request Oct 18, 2023
Merged
4 tasks
@GretaD GretaD requested a review from Pytal October 19, 2023 13:44
Pytal
Pytal approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor remark

@GretaD
Add the resource type on RelatedResourcesPanel
81cfec0 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD merged commit 9a55a95 into master Oct 20, 2023
15 checks passed
@GretaD GretaD deleted the feature/resource-type-prop branch October 20, 2023 08:11
@Pytal Pytal added the enhancement New feature or request label Oct 23, 2023
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GretaD @Pytal @ChristophWurst