Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcAppSidebarTabs): Make tab navigation accessible #4663

Merged
merged 8 commits into from
Oct 19, 2023
Merged

enh(NcAppSidebarTabs): Make tab navigation accessible #4663

merged 8 commits into from
Oct 19, 2023

Commits on Oct 18, 2023

  1. fix(NcAppSidebarTabs): Adjust styles 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8f6abb6 View commit details
    Browse the repository at this point in the history

  2. feat(NcCheckboxRadioSwitch): Sidebar tab usage 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5f8f3e2 View commit details
    Browse the repository at this point in the history

  3. feat(NcCheckboxRadioSwitch): Add NcCheckboxContent component 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e73200c View commit details
    Browse the repository at this point in the history

  4. fix(NcAppSidebarTabs): Always add aria-selected 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    a2e2c16 View commit details
    Browse the repository at this point in the history

  5. fix(NcAppSidebarTabs): Tests 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7538063 View commit details
    Browse the repository at this point in the history

  6. fix(NcCheckboxRadioSwitch): Enforce button type 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e9281b6 View commit details
    Browse the repository at this point in the history

  7. fix(NcAppSidebarTabs): Correct association between tab button and tab… 

    …panel

Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    012b900 View commit details
    Browse the repository at this point in the history

  8. fix(NcCheckboxRadioSwitch): Adjust styles 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal
    Pytal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ca5fda8 View commit details
    Browse the repository at this point in the history