Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix checkbox sizing #4760

Merged
merged 1 commit into from Nov 17, 2023
Merged

fix checkbox sizing #4760

merged 1 commit into from Nov 17, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 6, 2023

Fix nextcloud/server#41262

Before After
image image

@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews labels Nov 6, 2023
@szaimen szaimen added this to the 8.0.0 milestone Nov 6, 2023
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

raimund-schluessler
raimund-schluessler previously requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the height of NcCheckBoxRadioSwitch which should be 44 px:

Before:

Screenshot 2023-11-06 at 16-59-58 Nextcloud Vue Style Guide
After:
Screenshot 2023-11-06 at 17-00-19 Nextcloud Vue Style Guide

@raimund-schluessler raimund-schluessler added the feature: checkbox-radio-switch Related to the checkbox-radio-switch component label Nov 6, 2023
@szaimen szaimen force-pushed the enh/noid/fix-checkbox-sizing branch from c3ff08a to bf2de2b Compare November 7, 2023 10:19
@susnux susnux mentioned this pull request Nov 7, 2023
Merged
16 tasks
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 7, 2023
@szaimen szaimen marked this pull request as draft November 7, 2023 13:38
@susnux susnux modified the milestones: 8.0.0, 8.0.1 Nov 8, 2023
@nickvergessen nickvergessen modified the milestones: 8.0.1, 8.0.2 Nov 9, 2023
@AndyScherzinger AndyScherzinger modified the milestones: 8.0.2, 8.1.1 Nov 14, 2023
@szaimen szaimen marked this pull request as ready for review November 16, 2023 14:19
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 16, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Nov 16, 2023

Ready for re-review 👍

@susnux
Copy link
Contributor

susnux commented Nov 16, 2023

But please squash the commits

@szaimen
Copy link
Contributor Author

szaimen commented Nov 16, 2023

But please squash the commits

Can you do that please? I currently cannot check out the vue library at all due to
image

JuliaKirschenheuter
JuliaKirschenheuter reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it known that checkbox i moved to left now? Or another issue?

Screenshot from 2023-11-16 15-30-08

@JuliaKirschenheuter
Copy link
Contributor

master:

Screenshot from 2023-11-16 15-38-28

@raimund-schluessler raimund-schluessler mentioned this pull request Nov 16, 2023
Merged
@raimund-schluessler
Copy link
Contributor

But please squash the commits

Can you do that please? I currently cannot check out the vue library at all due to image

Although unrelated to this PR: These files should not be there. I removed them in #4837.

@szaimen
fix checkbox sizing
4779aed 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Nov 17, 2023

But please squash the commits

done 👍

@szaimen szaimen merged commit 5efc392 into master Nov 17, 2023
15 checks passed
@szaimen szaimen deleted the enh/noid/fix-checkbox-sizing branch November 17, 2023 09:34
@susnux susnux mentioned this pull request Nov 17, 2023
Merged
@Antreesy
Copy link
Contributor

Antreesy commented Nov 30, 2023 •
edited

Label text is now falling out of the flex container borders:

UPD: Fixed by Ferdinand after 8.2.0, just not referenced in this PR

@Antreesy Antreesy mentioned this pull request Nov 30, 2023
Closed
1 task
@nickvergessen nickvergessen mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

[BITV]: Icons on selected files are truncated
7 participants
@szaimen @susnux @JuliaKirschenheuter @raimund-schluessler @Antreesy @nickvergessen @AndyScherzinger