Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcModal): Adjust aria-label of close button #4778

Merged
merged 1 commit into from Nov 8, 2023
Merged

fix(NcModal): Adjust aria-label of close button #4778

merged 1 commit into from Nov 8, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 8, 2023 •
edited

☑️ Resolves

See this for details: nextcloud/server#40703 (comment)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 8, 2023
@susnux susnux mentioned this pull request Nov 8, 2023
Merged
16 tasks
@susnux
fix(NcModal): Adjust aria-label to fix nextcloud/server#40703
db4ee93 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 8.0.1 milestone Nov 8, 2023
@skjnldsv skjnldsv merged commit 4d08197 into master Nov 8, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/modal-close-label branch November 8, 2023 16:17
@nickvergessen nickvergessen mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

[BITV]: Modal window improvements
4 participants
@susnux @AndyScherzinger @skjnldsv @ShGKme