Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCheckboxRadioSwitch): Fix contrast of Radio switches using butt… #4791

Merged
merged 1 commit into from Nov 9, 2023
Merged

fix(NcCheckboxRadioSwitch): Fix contrast of Radio switches using butt… #4791

merged 1 commit into from Nov 9, 2023

Conversation

nickvergessen
Copy link
Contributor

…on-variant

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Bildschirmfoto vom 2023-11-09 12-07-52 Bildschirmfoto vom 2023-11-09 12-08-11

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Nov 9, 2023
@nickvergessen nickvergessen added this to the 8.0.1 milestone Nov 9, 2023
@nickvergessen nickvergessen self-assigned this Nov 9, 2023
@nickvergessen
fix(NcCheckboxRadioSwitch): Fix contrast of Radio switches using butt…
f261b94 
…on-variant

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/4785/tab-headers-and-checkboxes-contrast branch from 8e8cb8e to f261b94 Compare November 9, 2023 11:41
@nickvergessen nickvergessen merged commit 9a7aa31 into master Nov 9, 2023
15 checks passed
@nickvergessen nickvergessen deleted the bugfix/4785/tab-headers-and-checkboxes-contrast branch November 9, 2023 12:12
This was referenced Nov 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@mejo- mejo- mejo- approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

Sidebar headers are not visible enough
3 participants
@nickvergessen @jancborchardt @mejo-