Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSettingsDialog): unregisterSection should remove the section instead of remove all other #4798

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix(NcAppSettingsDialog): unregisterSection should remove the section instead of remove all other #4798

merged 2 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. fix(NcAppSettingsDialog): unregisterSection should remove the secti… 

    …on instead of remove all other

Also fix some minor issues and only warn on duplicated name instead of error

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c5eccf6 View commit details
    Browse the repository at this point in the history

  2. fix(NcAppSettingsDialog): Adjust tests to be independent from impleme… 

    …ntation

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @ShGKme
    susnux and ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    06b5c2b View commit details
    Browse the repository at this point in the history