Fix unregisterSection Bug in NcAppSettingsDialog #4808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
|
Because I don't have permissions in this repo, since the transfer to nextcloud-libraries I cannot add him as a reviewer, so I'll just leave a mention: @susnux you wrote the mentioned PR, please give this a review :) |
|
There are 2 PRs already that fixes this and some related issues:
The problem also caused by incorrect provide of the method. |
|
closed in favor of #4798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fixes "Error: Duplicate section id found: [any section id, that is used dynamically]. Settings navigation sections must have unique section ids." error, when enabling any previously disabled section using v-if.
This usage of dynamic sections is supported, but is broken since #4745, because of a very simple logic error: the unregisterSection function is supposed to filter out that particular section, that just got unregistered. Instead it currently removes any section besides of the unregistered one, leaving behind a broken component state.
🖼️ Screenshots
No design changes
🚧 Tasks
🏁 Checklist