Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): fix role and aria attributes #4835

Merged
merged 6 commits into from
Nov 16, 2023
Merged

fix(NcActions): fix role and aria attributes #4835

merged 6 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. chore(NcActions): add more examples 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    72db9e6 View commit details
    Browse the repository at this point in the history

  2. fix(NcActionSeparator): add role="separator" 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4281b8f View commit details
    Browse the repository at this point in the history

  3. fix(NcActions): always set aria-hidden on icon and deprecate prop for it 

    There is no case where icon may not but decorative.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    bc99043 View commit details
    Browse the repository at this point in the history

  4. fix(NcButton): always set aria-hidden on icon and deprecate prop for it 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ee218a6 View commit details
    Browse the repository at this point in the history

  5. fix(NcActionButtonGroup): add role=group and aria-labelledby 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    57878b6 View commit details
    Browse the repository at this point in the history

  6. fix(NcActions): set menu roles only in true menu 

    Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    63bc999 View commit details
    Browse the repository at this point in the history