Create scrollable content via min-height over sidebar and settings dialog on small screens
#4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
approved these changes
Nov 16, 2023
|
2 blocks with scrolls doesn't look good on a so small screen... What about:
cc @nextcloud-libraries/designers for ideas |
That is a good idea! Actually this navigation is not important on small screens. @marcoambrosini @nimishavijay would it work for you? |
The navigation was introduced by accident on mobile screens, meaning we should just remove it then again like before. |
JuliaKirschenheuter
force-pushed
the
fix/41542-Horizontal_scrolling_appears_on_small_screens_in_app_settings_navigation
branch
from
57295a6
to
375ff23
Compare
susnux
approved these changes
Nov 17, 2023
JuliaKirschenheuter
force-pushed
the
fix/41542-Horizontal_scrolling_appears_on_small_screens_in_app_settings_navigation
branch
from
375ff23
to
67864fc
Compare
susnux
reviewed
Nov 17, 2023
… in app settings navigation Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/41542-Horizontal_scrolling_appears_on_small_screens_in_app_settings_navigation
branch
from
67864fc
to
17d6da4
Compare
szaimen
reviewed
Nov 17, 2023
ShGKme
approved these changes
Nov 17, 2023
JuliaKirschenheuter
deleted the
fix/41542-Horizontal_scrolling_appears_on_small_screens_in_app_settings_navigation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create scrollable content via
min-heightover sidebar and settings dialog on small screens☑️ Resolves
🖼️ Screenshots
🏚️ Before
🏡 After
🏁 Checklist