Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDateTime): Also use months for relative date time #4845

Merged
merged 1 commit into from Nov 17, 2023
Merged

fix(NcDateTime): Also use months for relative date time #4845

merged 1 commit into from Nov 17, 2023

Conversation

nickvergessen
Copy link
Contributor

Follow up to #4832

🖼️ Screenshots

🏚️ Before 🏡 After
Bildschirmfoto vom 2023-11-17 09-19-42 3 months ago
3 months ago
8 months ago
10 months ago
10 months ago
11 months ago

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@nickvergessen
fix(NcDateTime): Also use months for relative date time
7ab87e4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 17, 2023
@nickvergessen nickvergessen added this to the 8.1.1 milestone Nov 17, 2023
@nickvergessen nickvergessen self-assigned this Nov 17, 2023
@nickvergessen nickvergessen merged commit 8703e8b into master Nov 17, 2023
15 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/improve-relative-time-handling branch November 17, 2023 08:46
@susnux
Copy link
Contributor

susnux commented Nov 17, 2023

Months... who needs them when you can say your dates with calendar weeks 😛

@susnux susnux mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickvergessen @susnux @blizzz @raimund-schluessler