Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCheckboxContent): Make sure text can wrap #4862

Merged
merged 1 commit into from Nov 22, 2023
Merged

fix(NcCheckboxContent): Make sure text can wrap #4862

merged 1 commit into from Nov 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 21, 2023

☑️ Resolves

Ensure the text of the checkbox label does not overflow the label.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-11-21 at 15-26-09 Nextcloud Vue Style Guide Screenshot 2023-11-21 at 15-26-34 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 21, 2023
@susnux
fix(NcCheckboxContent): Make sure text wraps
394af38 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2023
@Pytal Pytal merged commit 7d25883 into master Nov 22, 2023
15 checks passed
@Pytal Pytal deleted the fix/checkbox-content-fle branch November 22, 2023 00:15
@Antreesy Antreesy mentioned this pull request Nov 30, 2023
Closed
@nickvergessen nickvergessen added this to the 8.2.1 milestone Nov 30, 2023
@susnux susnux mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@susnux @Pytal @ShGKme @nickvergessen