fix(NcAppSettingsDialog): Remove navigation instead of hiding and fix styles #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… styles Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
susnux
requested review from
JuliaKirschenheuter,
marcoambrosini and
szaimen
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
marcoambrosini
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Instead of hiding the navigation on small devices, remove it (and clean up the styles as they are not needed anymore).
Also fix dialog styles (content & navigation) which need to have the
deepselector to be applied.Fixed the padding which is now already (partly) included by NcDialog.
🖼️ Screenshots
🏁 Checklist