fix(NcDialog): Add slighly more padding on the bottom and fix example button order #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
raimund-schluessler,
Pytal,
marcoambrosini and
nimishavijay
raimund-schluessler
approved these changes
Nov 28, 2023
ShGKme
approved these changes
Nov 28, 2023
marcoambrosini
approved these changes
Nov 28, 2023
… button order Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/ncdialog-example
branch
from
77100cd
to
5b44909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
On the OCDialogs.confirm and everywhere else we use
left: secondary action
right: primary action
So I adjusted the example for this.
And also add slightly more padding on the bottom in case there is only text shown, so that the padding on the left / right and bottom is the same.
🖼️ Screenshots
🏁 Checklist