Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): use valid JSDoc for literal type union #4886

Merged
merged 1 commit into from Nov 30, 2023
Merged

chore(lint): use valid JSDoc for literal type union #4886

merged 1 commit into from Nov 30, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2023

@values is not valid in JSDoc by out ESLint rules.

@type with literal type union works in the styleguidist as well

@ShGKme
chore(lint): use valid JSDoc for literal type union
3ac2dd5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Nov 29, 2023
@susnux susnux merged commit 81641b3 into master Nov 30, 2023
15 checks passed
@susnux susnux deleted the chore/lint branch November 30, 2023 15:28
@susnux susnux mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @susnux @Pytal