Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): replace custom v-tooltip with native title #4888

Merged
merged 1 commit into from Nov 29, 2023
Merged

fix(NcAppNavigation): replace custom v-tooltip with native title #4888

merged 1 commit into from Nov 29, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcAppNavigation): replace v-tooltip with native title
66392b2 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 29, 2023
@ShGKme ShGKme added this to the 8.2.1 milestone Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 29, 2023
@ShGKme ShGKme mentioned this pull request Nov 29, 2023
Closed
szaimen
szaimen approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didn test

@Pytal Pytal merged commit d9d3e74 into master Nov 29, 2023
15 checks passed
@Pytal Pytal deleted the fix/nc-app-navigation--remove-v-tooltip branch November 29, 2023 19:59
@susnux susnux mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.2.1
4 participants
@ShGKme @Pytal @szaimen @nimishavijay