Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcColorPicker): correct aria-label #4889

Merged
merged 1 commit into from Nov 30, 2023
Merged

fix(NcColorPicker): correct aria-label #4889

merged 1 commit into from Nov 30, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2023

@ShGKme
fix(NcColorPicker): correct aria-label
79e6885 
`aria-label` should be set directly on the element being labelled.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: colorpicker Related to the colorpicker component labels Nov 29, 2023
@ShGKme ShGKme added this to the 8.2.1 milestone Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 29, 2023
@ShGKme ShGKme mentioned this pull request Nov 29, 2023
Closed
szaimen
szaimen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit 40a84dc into master Nov 30, 2023
15 checks passed
@susnux susnux deleted the fix/nc-color-picker--correct-aria-label branch November 30, 2023 11:35
@susnux susnux mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: colorpicker Related to the colorpicker component
Projects
None yet
Milestone
8.2.1
4 participants
@ShGKme @susnux @Pytal @szaimen