Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDialog): Increase specificity for modal-content selector #4897

Merged
merged 1 commit into from Nov 30, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 30, 2023

☑️ Resolves

This is a quick hack to solve the problem. But ideally we should not rely on any classes from NcModal at all.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Nov 30, 2023
@ShGKme ShGKme merged commit 5cc6c04 into master Nov 30, 2023
15 checks passed
@ShGKme ShGKme deleted the fix/modal-styles branch November 30, 2023 21:34
@susnux susnux modified the milestones: 8.4.0, 8.3.1 Dec 20, 2023
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: dialog Related to the dialog component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialogs styles are overridden by NcModal styles
3 participants