fix(NcRichContenteditable): make autocomplete accessible #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
force-pushed
the
fix/nc-rich-contenteditable--a11y-tribute
branch
from
23fdbae
to
16d225f
Compare
- Fixes `Tribute was already bound to DIV` warning - Tribute is supposed to be only once on the element - Simplifies further work with Tribute Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
- `smilesList` is always a constant and reused across all the instances - tribute options are used only once to initialize tribute Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
- Correctly implement `debounced` method, so that debouncedFunction properties are available and each component instance has its own debounce - Clear debounce on autoComplete close Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-rich-contenteditable--a11y-tribute
branch
from
98b6a12
to
5a90fc3
Compare
JuliaKirschenheuter
approved these changes
Feb 5, 2024
ShGKme
force-pushed
the
fix/nc-rich-contenteditable--a11y-tribute
branch
2 times, most recently
from
8ac2eba
to
f91c871
Compare
ShGKme
added
3. to review
Merged
2 tasks
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-rich-contenteditable--a11y-tribute
branch
from
f91c871
to
66034a3
Compare
ShGKme
commented
Feb 5, 2024
Comment on lines
+937
to
+941
| // Setup integration only once on the first open | ||
| if (this.isTributeIntegrationDone) { | ||
| return | ||
| } | ||
| this.isTributeIntegrationDone = true |
There was a problem hiding this comment.
The only thing added during the force push.
To set up integration only once after the first open, not each time.
|
Sorry for a fast merge, rushing to get this in the tomorrow's release. Feel free to review merged, I'll have a look. |
ShGKme
added a commit
that referenced
this pull request
Feb 5, 2024
…editable--a11y-tribute fix(NcRichContenteditable): make autocomplete accessible
ShGKme
added a commit
that referenced
this pull request
Feb 5, 2024
…editable--a11y-tribute fix(NcRichContenteditable): make autocomplete accessible
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The solution may look a bit complex with dirty places, but I see no better solution except forking
Tribute.js.Complex parts with tribute:
tribute-active-truedoes not respect async loadingactivedescendanttribute-active-trueevent. Tribute is supposed to be used only once on elementcontainerClassis not updating on opening another collection (known Tribute.js issue)refactor(NcRichContenteditable): create 1 tribute for all autocompletes
Tribute was already bound to DIVwarningrefactor(NcRichContenteditable): move constants out of reactive data
Not required, but simplifies work with actual component's state.
smilesListis always a constant and reused across all the instancesrefactor(NcRichContenteditable): cancel autoComplete on close
debouncedmethod, so thatdebouncedFunctionproperties are available and each component instance has its owndebounce.debouncedis not valid in Vue. In this case, we have 1 shared debounce for all component instances.autoCompleteclosefix(NcRichContenteditable): make autocomplete accessible
aria-*attributes to thecontenteditablearia-activedescendantto connect with the current selected element from autocompletelistbox+optioninstead of nativelist+listitemlistdoesn't work as a list of options for screen readerfix(NcRichContenteditable): provide focus-visible class
:focus-visible🖼️ Screenshots
🏁 Checklist