Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcBreadcrumbs): Allow setting aria-label on nav #4913

Merged
merged 1 commit into from Dec 5, 2023
Merged

enh(NcBreadcrumbs): Allow setting aria-label on nav #4913

merged 1 commit into from Dec 5, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 5, 2023

Summary

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal
enh(NcBreadcrumbs): Allow setting aria-label on nav
b141cf2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: breadcrumbs Related to the breadcrumbs components labels Dec 5, 2023
@Pytal Pytal added this to the 8.4.0 milestone Dec 5, 2023
@Pytal Pytal self-assigned this Dec 5, 2023
@raimund-schluessler raimund-schluessler merged commit 5e8408e into master Dec 5, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the enh/a11y/breadcrumbs-nav branch December 5, 2023 06:35
@ShGKme ShGKme added the enhancement New feature or request label Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 馃榾

@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @ShGKme @raimund-schluessler