Add target prop for NcListItem #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
added a commit
to nextcloud/server
that referenced
this pull request
Dec 6, 2023
Following the update of `NcListItem` to allow control over where and how passed `hrefs` open, the search result component can now make use of these props. See : nextcloud-libraries/nextcloud-vue#4923 Resolves : #41800 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
ShGKme
reviewed
Dec 6, 2023
susnux
reviewed
Dec 6, 2023
Fenn-CS
force-pushed
the
respect-target-attribute-nclistitem
branch
from
bdcfe3c
to
4f307ec
Compare
Fenn-CS
added a commit
to nextcloud/server
that referenced
this pull request
Dec 6, 2023
Following the update of `NcListItem` to allow control over where and how passed `hrefs` open, the search result component can now make use of these props. See : nextcloud-libraries/nextcloud-vue#4923 Resolves : #41800 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
respect-target-attribute-nclistitem
branch
from
4f307ec
to
fccba1f
Compare
The component user should have full control over what tab they want the link to open in, if any. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
respect-target-attribute-nclistitem
branch
from
fccba1f
to
abeeef2
Compare
susnux
approved these changes
Dec 6, 2023
Pytal
approved these changes
Dec 6, 2023
backportbot-nextcloud bot
pushed a commit
to nextcloud/server
that referenced
this pull request
Dec 6, 2023
Following the update of `NcListItem` to allow control over where and how passed `hrefs` open, the search result component can now make use of these props. See : nextcloud-libraries/nextcloud-vue#4923 Resolves : #41800 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
zak39
pushed a commit
to zak39/server
that referenced
this pull request
Dec 19, 2023
Following the update of `NcListItem` to allow control over where and how passed `hrefs` open, the search result component can now make use of these props. See : nextcloud-libraries/nextcloud-vue#4923 Resolves : nextcloud#41800 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
ShGKme
added
feature: list-item
|
Remember to add |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component user should have full control over what tab they want the link to open in, if any.
☑️ Resolves
NcListItemwould force open on a new tab if href present. #4880🚧 Tasks
🏁 Checklist