enh(NcInputField): Support numeric values - if numeric also emit numeric #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
requested review from
raimund-schluessler,
Pytal,
ShGKme and
marcoambrosini
Pytal
approved these changes
Dec 6, 2023
ShGKme
reviewed
Dec 7, 2023
susnux
force-pushed
the
enh/ncinputfield-support-numeric-value
branch
from
b6d88ac
to
68abfbb
Compare
ShGKme
approved these changes
Jan 21, 2024
If the type is set to number and a number is passed as value also emit a number instead of a string. Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
enh/ncinputfield-support-numeric-value
branch
from
68abfbb
to
a41711a
Compare
Well then remove with v9 and vue 3 :) |
Merged
Antreesy
reviewed
Jan 29, 2024
| @@ -53,7 +53,7 @@ For a list of all available props and attributes, please check the [HTMLInputEle | |||
| 'input-field__input--error': error, | |||
| 'input-field__input--pill': pill, | |||
| }]" | |||
| :value="value" | |||
| :value="value.toString()" | |||
| v-on="$listeners" | |||
| @input="handleInput"> | |||
There was a problem hiding this comment.
Just to raise awareness (as i spend quite a time to understand it 🙈):
- TextField don't listen for
@update:value, but for@input - As it wasn't modified by this PR, TextField always emits a string
Is it expected? As InputField is marked as internal component, we usually avoid to use it directly in the app
What should we do?
- update vue-lib docs, and 'allow' to use InputField?
- expand PR changes to TextField? (not sure about rest wrappers)
There was a problem hiding this comment.
Basically a lot of apps use NcInputField because of the button limitations (NcTextField does not allow any kind of trailing button).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
If the type is set to number and a number is passed as value also emit a number instead of a string.
It always bugs me that you have to write wrappers otherwise, example:
vs with this:
🏁 Checklist