Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcDialog): Label dialog nav #4928

Merged
merged 1 commit into from Dec 7, 2023
Merged

enh(NcDialog): Label dialog nav #4928

merged 1 commit into from Dec 7, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 7, 2023

Summary

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal
enh(NcDialog): Label dialog nav
1be420f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: dialog Related to the dialog component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 7, 2023
@Pytal Pytal added this to the 8.4.0 milestone Dec 7, 2023
@Pytal Pytal self-assigned this Dec 7, 2023
@Pytal Pytal enabled auto-merge December 7, 2023 01:40
@Pytal Pytal merged commit 42503f7 into master Dec 7, 2023
15 checks passed
@Pytal Pytal deleted the enh/a11y/dialog-nav branch December 7, 2023 15:51
ShGKme pushed a commit that referenced this pull request Dec 11, 2023
@Pytal @ShGKme
Merge pull request #4928 from nextcloud-libraries/enh/a11y/dialog-nav
abe1f8b 
enh(NcDialog): Label dialog nav
@ShGKme ShGKme added the bug Something isn't working label Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 馃榾

@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @ShGKme @susnux