Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigationSettings): remove incorrect aria-label #4932

Merged
merged 1 commit into from Dec 7, 2023
Merged

fix(NcAppNavigationSettings): remove incorrect aria-label #4932

merged 1 commit into from Dec 7, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 7, 2023 •
edited

@ShGKme
fix(NcAppNavigationSettings): remove incorrect aria-label
7294a5b 
This button has a label already from its text content.
It should not have a different `aria-label`.
"Open" action is covered by `aria-expanded`.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 7, 2023
@ShGKme ShGKme added this to the 8.3.1 milestone Dec 7, 2023
@ShGKme ShGKme self-assigned this Dec 7, 2023
@ShGKme ShGKme merged commit 6e6e490 into master Dec 7, 2023
16 checks passed
@ShGKme ShGKme deleted the fix/app-navigation-settings--correct-label branch December 7, 2023 16:15
ShGKme added a commit that referenced this pull request Dec 11, 2023
@ShGKme
Merge pull request #4932 from nextcloud-libraries/fix/app-navigation-…
7827e06 
…settings--correct-label

fix(NcAppNavigationSettings): remove incorrect aria-label
This was referenced Dec 19, 2023
Closed
Merged
@ShGKme ShGKme mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.3.1
3 participants
@ShGKme @susnux @szaimen