Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equalize TextArea styles with TextField styles #4971

Merged
merged 1 commit into from Dec 18, 2023
Merged

Equalize TextArea styles with TextField styles #4971

merged 1 commit into from Dec 18, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

Before After
Screenshot from 2023-12-18 16-44-20 Screenshot from 2023-12-18 16-25-40
image Screenshot from 2023-12-18 16-25-26
Screenshot from 2023-12-18 16-24-50

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter
Equalize TextArea styles with TextField styles
05aebf1 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 18, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 18, 2023
@susnux susnux added this to the 8.3.1 milestone Dec 18, 2023
emoral435
emoral435 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local dev and the contrast looks good to me 👍

@emoral435 emoral435 merged commit da340d6 into master Dec 18, 2023
15 checks passed
@emoral435 emoral435 deleted the fix/42243-adapt_textarea_styles branch December 18, 2023 16:22
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 😀

@ShGKme ShGKme modified the milestones: 8.3.1, 8.4.0 Dec 22, 2023
@ShGKme ShGKme added bug Something isn't working feature: input-field Covering the InputField, TextField, ... labels Dec 22, 2023
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@emoral435 emoral435 emoral435 approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@ShGKme ShGKme Awaiting requested review from ShGKme

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace label styles of NcTextArea with styles from NcTextField
4 participants
@JuliaKirschenheuter @ShGKme @susnux @emoral435