Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat(NcRich*): migrate to vue 3 #4976

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[next] feat(NcRich*): migrate to vue 3 #4976

merged 1 commit into from
Dec 21, 2023

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

  • Migrate NcRich* components to vue 3.

@raimund-schluessler
Copy link
Contributor Author

@Antreesy Thanks a lot for taking care of the remaining issues! Markdown support works now and I couldn't find any more issues. From my side, this PR is now ready to be merged.

When this gets merged, we have migrated all components to vue3 🚀

I will squash the commits into one after the PR is approved.

@raimund-schluessler raimund-schluessler mentioned this pull request Dec 19, 2023
Closed
@raimund-schluessler raimund-schluessler marked this pull request as ready for review December 19, 2023 16:53
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Dec 19, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component vue 3 Related to the vue 3 migration labels Dec 19, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 20, 2023

When this gets merged, we have migrated all components to vue3 🚀

Except NcReferencePicker 😶

@raimund-schluessler
Copy link
Contributor Author

When this gets merged, we have migrated all components to vue3 🚀

Except NcReferencePicker 😶

This is included in this PR as well, since it sits in the NcRichText directory. I don't have an app that uses the picker though. So if one would test it, it would be great. But in doubt, it will be tested once the first app that uses it gets migrated. The first release of nextcloud-vue@next will be an alpha version meant for testing anyways.

@raimund-schluessler

This comment was marked as resolved.

Sign in to view
@ShGKme

This comment was marked as resolved.

Sign in to view
@raimund-schluessler

This comment was marked as resolved.

Sign in to view
@raimund-schluessler raimund-schluessler force-pushed the feat/2154/rich-patches branch 2 times, most recently from f65ab1c to 9a6b526 Compare December 20, 2023 20:39
@raimund-schluessler
Copy link
Contributor Author

When this gets merged, we have migrated all components to vue3 🚀

Except NcReferencePicker 😶

I applied the review comments and fixed another issue I found. I think it should work well now, a new review would be welcome.

ShGKme
ShGKme approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work fine.

Thanks for all the work 💙
And for resolving a large number of my comments 🙈

The last component in Vue 3 migration 🚀

Antreesy
Antreesy approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from NcRich component general usage + markdown (apart from the code where I'm co-author)

susnux
susnux approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@susnux
Copy link
Contributor

susnux commented Dec 21, 2023

Unrelated, but does anyone knows where this is coming from?
Tribute was already bound to DIV

@raimund-schluessler
Copy link
Contributor Author

Everything seems to work fine.

Great.

Thanks for all the work 💙 And for resolving a large number of my comments 🙈

Thanks for your comments, though. They helped a lot!

The last component in Vue 3 migration 🚀

I think it's time for an alpha release, no? 🙂

@raimund-schluessler
feat(NcRich*): migrate to vue 3
e7d25a8 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler linked an issue Dec 21, 2023 that may be closed by this pull request
Migrate to Vue 3 #2154
Closed
20 tasks
@raimund-schluessler raimund-schluessler merged commit c1154b3 into next Dec 21, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the feat/2154/rich-patches branch December 21, 2023 14:56
@raimund-schluessler raimund-schluessler mentioned this pull request Dec 21, 2023
Closed
20 tasks
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Migrate to Vue 3
4 participants
@raimund-schluessler @ShGKme @susnux @Antreesy