fix(NcAppNavigationItem): fix style when using active prop
#4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/appnavigationitem-active-prop
branch
from
70b7a9b
to
dc41791
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/appnavigationitem-active-prop
branch
from
ac6ac1c
to
194e3ad
Compare
raimund-schluessler
added
bug
raimund-schluessler
requested review from
susnux,
skjnldsv,
Pytal and
ShGKme
susnux
approved these changes
Dec 23, 2023
ShGKme
approved these changes
Dec 24, 2023
raimund-schluessler
deleted the
fix/noid/appnavigationitem-active-prop
branch
Merged
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcAppNavigationItemhad the wrong colors on the utils set when using theactiveprop instead of lettingvue-routerset theactivestate. This is fixed here. I also corrected the HTML structure of the examples (ulwas missing) and adjusted the cypress tests to cover theactiveprop issue.🖼️ Screenshots