Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcModal): Set return focus element on focus trap deactivation #5025

Merged
merged 1 commit into from Jan 4, 2024
Merged

feat(NcModal): Set return focus element on focus trap deactivation #5025

merged 1 commit into from Jan 4, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 4, 2024

Summary

Allow setting the return focus element

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal
feat(NcModal): Set return focus element on focus trap deactivation
74edf1c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews feature: modal Related to the modal component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 4, 2024
@Pytal Pytal added this to the 8.5.0 milestone Jan 4, 2024
@Pytal Pytal self-assigned this Jan 4, 2024
@Pytal Pytal mentioned this pull request Jan 4, 2024
Merged
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2024
@Pytal Pytal merged commit d224092 into master Jan 4, 2024
15 checks passed
@Pytal Pytal deleted the feat/modal-return-focus branch January 4, 2024 17:05
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge Awaiting requested review from artonge

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: modal Related to the modal component
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @JuliaKirschenheuter @ShGKme